Add all remaining templates folders to import/order #58462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
May 7, 2024
apps/src/templates/projects/frozenProjectInfoDialog/FrozenProjectInfoDialog.tsx
Outdated
Show resolved
Hide resolved
| @@ -445,4 +445,3 @@ tr.introjs-showElement > th { | |||
| z-index: 1; | |||
| opacity: 0; | |||
| } | |||
| /*# sourceMappingURL=introjs.css.map */ | |||
There was a problem hiding this comment.
Uuuugh, haven't merged my fix yet
This reverts commit 04e47f2.
Hamms
reviewed
May 9, 2024
# Conflicts: # apps/src/templates/rubrics/introjs.scss
Hamms
approved these changes
May 10, 2024
| import PropTypes from 'prop-types'; | ||
| import style from './rubrics.module.scss'; | ||
| import i18n from '@cdo/locale'; | ||
| // Disabling import/order rule for this file because product tour imports are grouped. |
| import {DELETE_SUCCESS} from './deleteDialog/deleteProjectDialogRedux'; | ||
| import {channels as channelsApi} from '../../clientApi'; | ||
| import LibraryClientApi from '@cdo/apps/code-studio/components/libraries/LibraryClientApi'; | ||
| // Disabling import order due to circular dependencies errors from build. |
There was a problem hiding this comment.
I would still like to see some more specificity here about what exactly the circular dependency is. One purpose for comments like this is to help future developers identify when the exception to the norm we've introduced could be removed.
| // Disabling import order due to circular dependencies errors from build. | ||
| import {DELETE_SUCCESS} from './deleteDialog/deleteProjectDialogRedux'; /* eslint-disable-line import/order */ | ||
| import {channels as channelsApi} from '../../clientApi'; /* eslint-disable-line import/order */ | ||
| import LibraryClientApi from '@cdo/apps/code-studio/components/libraries/LibraryClientApi'; /* eslint-disable-line import/order */ |
There was a problem hiding this comment.
Is there a specific reason you're disabling these line-by-line rather than as a block?
| @@ -1,12 +1,18 @@ | |||
| import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
| import VersionRow from './VersionRow'; | |||
|
|
|||
| // Disabling import order due to circular dependencies errors from build. | |||
There was a problem hiding this comment.
As above, I'd like to see some more details in this comment, and I'm curious why we're disabling the rule line-by-line rather than as a group.
# Conflicts: # apps/src/templates/sessions/LockoutPanel.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve code cleanliness slightly, we are rolling out an eslint rule to the entire repo that ensure .js, .jsx, .ts and .tsx files have imports automatically sorted.
We are rolling this out incrementally to prevent errors and decrease PR size. This PR removes a subset of folders from the rule exclusions.
FLUP of #57247
For PR reviewers: please double check that all comments in imports are appropriately moved with the line they are talking about.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: