Fix Violations of and Reenable Style/HashTransformValues and Style/HashTransformKeys

[Hamms]

These are both pretty straightforward:

Looks for uses of _.each_with_object({}) …, _.map ….to_h, and Hash[_.map …] that are actually just transforming the keys/values of a hash, and tries to use a simpler & faster call to transform_keys/transform_values instead.

TIL that these methods exist!

Changes applied automatically with

bundle exec rubocop --autocorrect-all --only Style/HashTransformKeys
bundle exec rubocop --autocorrect-all --only Style/HashTransformValues

Changes seem straightforward and safe, and look consistently like clear improvements to me. Please let me know if you disagree, but this one seems like an easy win!

Links

• https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformkeys
• https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformvalues
• https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformKeys
• https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/HashTransformValues

Testing story

Relying on existing tests to verify that none of these changes result in any difference to functionality.

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[davidsbailey]

the autocorrect option is a nice confidence boost!

[wilkie]

Looks great!