Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update Ruby to 3.0.5"" #52617

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 5, 2023

Reverts #52597, reapplying #50743.

The last attempt failed because Ruby 3.0 takes a much more aggressive stance toward preventing the user from using Dir.chdir in a thread-unsafe way, which we have since addressed in #52619

Testing Story

We successfully built and installed Ruby 3.0 on the staging and test servers in the last attempt, and all tests on the test server passed when run manually in serial rather than automatically in parallel. I also verified that with #52619 we are again successfully able to run tests automatically in parallel on Ruby 3.

@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label Jul 5, 2023
@Hamms Hamms marked this pull request as ready for review July 6, 2023 19:21
@Hamms Hamms requested a review from a team as a code owner July 6, 2023 19:21
@Hamms Hamms merged commit 164d773 into staging Jul 10, 2023
2 checks passed
@Hamms Hamms deleted the revert-52597-revert-50743-ruby-3.0.5 branch July 10, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant