Update rake Gem to v12
#50908
Merged
Update rake Gem to v12
#50908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically to pick up ruby/rake#211, which is required for Rails 6.1 support; without it, we get `undefined method \`with_application' for Rake:Module (NoMethodError)` when trying to run any rails script. Note that we specifically implement this by updating the `scss_lint` gem to pick up the change "Relax gem dependency constraints to allow rake 12.x" - https://github.com/sds/scss-lint/blob/master/CHANGELOG.md#0510 - https://github.com/ruby/rake/releases/tag/v12.2.0
Hamms
added
the
Rails Upgrade
sureshc
approved these changes
Mar 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically to pick up ruby/rake#211, which is required for Rails 6.1 support; without it, we get
undefined method ``with_application' for Rake:Module (NoMethodError)when trying to run any rails script.Specifically, I implemented this by running
bundle update rake scss_lint --conservative;scss_lintto pick up the change "Relax gem dependency constraints to allow rake 12.x", and--conservativeto avoid also updating thesassgem, just to keep this changeset scoped.Links
Testing story
Tested locally that this resolves for me the problems with running rake tasks on Rails 6.1
Relying on existing tests to verify that this does not otherwise result in any change to functionality.