Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haml gem to 5.2.0 #45007

Merged
merged 2 commits into from Feb 26, 2022
Merged

Update haml gem to 5.2.0 #45007

merged 2 commits into from Feb 26, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 23, 2022

Switching us back to the mainline gem, from our custom fork. All modifications we made to our custom fork were accepted into the mainline gem as part of the 5.1.0 release.

Links

Original Issues

Fix PRs

Testing story

Relying on existing unit tests.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Switching us back to the mainline gem, from our custom fork.
Will's original implementation gave this option the name `escape_interpolated_html`, but it was changed to `escape_filter_interpolations` in the review process
@Hamms Hamms marked this pull request as ready for review February 24, 2022 23:12
@Hamms Hamms requested a review from a team February 24, 2022 23:12
@sureshc
Copy link
Contributor

sureshc commented Feb 25, 2022

This looks like a simple change to me, but maybe teams that depend on our usage of HAML should take a look as well? Possibly Foundations, since we may do localization within HAML?

@Hamms Hamms merged commit 792eee8 into staging Feb 26, 2022
@Hamms Hamms deleted the haml-5.2.0 branch February 26, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants