feature: Add report list as parameter #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
franciscodua
commented
May 4, 2020
franciscodua
commented
- Users can specify a list of reports to send
- We always send a final signal, even if we only need to send one report
franciscodua
requested review from
mrfyda,
andreaTP,
lolgab,
josemiguelmelo and
a team
| fi | ||
| done | ||
|
|
||
| bash <(curl -Ls https://coverage.codacy.com/get.sh) report $params --partial &&\ |
There was a problem hiding this comment.
Do you need the &&\?
There was a problem hiding this comment.
Without it, we run the second action even if the first failed. Which shouldn't happen
lolgab
requested changes
May 4, 2020
| required: true | ||
| coverage-reports: | ||
| description: 'Optional comma separated list of coverage reports to send to Codacy' |
There was a problem hiding this comment.
Can we have a real yaml list instead a comma separated string?
There was a problem hiding this comment.
We can't unfortunately. Github actions doesn't support it yet
There was a problem hiding this comment.
lolgab
approved these changes
May 5, 2020
This was referenced May 5, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.