Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip-uncommitted-files-check flag to GH action #70

Merged
merged 2 commits into from Mar 3, 2022
Merged

Add skip-uncommitted-files-check flag to GH action #70

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6474ca1
Update action.yml
heliocodacy Mar 3, 2022
4d04001
Update action.yml
heliocodacy Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions action.yml
View file
Open in desktop
Expand Up @@ -79,6 +79,10 @@ inputs:
required: false
description: >-
Path to a file containing the output of Faux Pas.
skip-uncommitted-files-check:
required: false
description: >-
skip validation on uncommited files
heliocodacy marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

Suggested change
skip validation on uncommited files
Skip validation on uncommitted files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be more correct to talk about "uncommitted changes" (as mentioned on the possible status code). This is because a file can have some changes committed and some changes not committed at the same time. But I noticed that the Codacy Analysis CLI already includes the same flag mentioning files. 🤷‍♂️

runs:
using: "composite"
steps:
Expand Down Expand Up @@ -248,6 +252,7 @@ runs:
$(if [ -n "${{ inputs.max-allowed-issues }}" ]; then echo "--max-allowed-issues ${{ inputs.max-allowed-issues }}"; fi) \
$(if [ -n "${{ inputs.tool }}" ]; then echo "--tool ${{ inputs.tool }}"; fi) \
$(if [ -n "${{ inputs.tool-timeout }}" ]; then echo "--tool-timeout ${{ inputs.tool-timeout }}"; fi) \
$(if [ "${{ inputs.skip-uncommitted-files-check }}" = "true" ]; then echo "--skip-uncommitted-files-check"; fi) \
$(if [ "${{ inputs.upload }}" = "true" ]; then echo "--upload"; fi) \
$(if [ "${{ inputs.fail-if-incomplete }}" = "true" ]; then echo "--fail-if-incomplete"; fi) \
$(if [ "${{ inputs.allow-network }}" = "true" ]; then echo "--allow-network"; fi) \
Expand Down