Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action.yml to support --upload-batch-size parameter #69

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Update action.yml to support --upload-batch-size parameter #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66212fb
fix: add support for --upload-batch-size parameter CY-5756
pedrocodacy Mar 2, 2022
44a0029
Apply suggestions from code review
pedrocodacy Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ inputs:
upload:
required: false
description: "Upload analysis results to Codacy"
upload-batch-size:
required: false
description: "Size of result batches to be uploaded to Codacy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention the unit for the batch size. I'm guessing it's bytes? The Codacy Analysis CLI doesn't mention it either.

pedrocodacy marked this conversation as resolved.
Show resolved Hide resolved
fail-if-incomplete:
required: false
description: "Fail the analysis if any tool fails to run"
Expand Down Expand Up @@ -219,7 +222,7 @@ runs:

- name: "Set Codacy CLI version"
shell: bash
run: echo "CODACY_ANALYSIS_CLI_VERSION=7.0.5" >> $GITHUB_ENV
run: echo "CODACY_ANALYSIS_CLI_VERSION=7.5.0" >> $GITHUB_ENV
- name: "Set script path environment variable"
shell: bash
run: echo "CLI_SCRIPT_PATH=${{ github.action_path }}/codacy-analysis-cli.sh" >> $GITHUB_ENV
Expand Down Expand Up @@ -249,6 +252,7 @@ runs:
$(if [ -n "${{ inputs.tool }}" ]; then echo "--tool ${{ inputs.tool }}"; fi) \
$(if [ -n "${{ inputs.tool-timeout }}" ]; then echo "--tool-timeout ${{ inputs.tool-timeout }}"; fi) \
$(if [ "${{ inputs.upload }}" = "true" ]; then echo "--upload"; fi) \
$(if [ -n "${{ inputs.upload-batch-size }}" ]; then echo "--upload-batch-size ${{ inputs.upload-batch-size }}"; fi) \
$(if [ "${{ inputs.fail-if-incomplete }}" = "true" ]; then echo "--fail-if-incomplete"; fi) \
$(if [ "${{ inputs.allow-network }}" = "true" ]; then echo "--allow-network"; fi) \
$(if [ "${{ inputs.force-file-permissions }}" = "true" ]; then echo "--force-file-permissions"; fi) \
Expand Down