Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip-uncommitted-files-check flag to GH action #70

Merged
merged 2 commits into from Mar 3, 2022

Conversation

heliocodacy
Copy link
Contributor

No description provided.

@heliocodacy heliocodacy changed the title Update action.yml Add skip-uncommitted-files-check flag to GH action Mar 3, 2022
action.yml Outdated Show resolved Hide resolved
Co-authored-by: Joao Machado <machado@codacy.com>
@heliocodacy heliocodacy merged commit 028de6e into master Mar 3, 2022
@heliocodacy heliocodacy deleted the add-skip-uncommitted-files-check branch March 3, 2022 16:04
action.yml Outdated
skip-uncommitted-files-check:
required: false
description: >-
skip validation on uncommited files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

Suggested change
skip validation on uncommited files
Skip validation on uncommitted files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be more correct to talk about "uncommitted changes" (as mentioned on the possible status code). This is because a file can have some changes committed and some changes not committed at the same time. But I noticed that the Codacy Analysis CLI already includes the same flag mentioning files. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants