Update action.yml to support --upload-batch-size parameter #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrocodacy
requested review from
lolgab,
lucassklp,
lventura-codacy,
machadoit,
rubencodacy,
stefanvacareanu7 and
vascorsd
stefanvacareanu7
previously approved these changes
Mar 2, 2022
|
If it helps the subsequent discussion, this was the pull request where we started to pin the Codacy Analisis CLI version used by the GitHub Action: #11 |
lucassklp
previously approved these changes
Mar 3, 2022
prcr
reviewed
Mar 3, 2022
action.yml
Outdated
| @@ -43,6 +43,9 @@ inputs: | |||
| upload: | |||
| required: false | |||
| description: "Upload analysis results to Codacy" | |||
| upload-batch-size: | |||
| required: false | |||
| description: "Size of result batches to be uploaded to Codacy" | |||
There was a problem hiding this comment.
We should mention the unit for the batch size. I'm guessing it's bytes? The Codacy Analysis CLI doesn't mention it either.
pedrocodacy
commented
Mar 4, 2022
pedrocodacy
dismissed stale reviews from lucassklp and stefanvacareanu7
via
44a0029
vascorsd
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did not know we were maintaining the version of the CLI manually here, any reasons fo us to not be using latest? (not changing that for now)