Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes in MkDocs Material 9 #2558

Merged
merged 1 commit into from Apr 10, 2023
Merged

Fix breaking changes in MkDocs Material 9 #2558

merged 1 commit into from Apr 10, 2023

Conversation

ekoleda-codaio
Copy link
Contributor

In #2519 the MkDocs Material library was upgraded to a new major version, which introduced some breaking changes. Namely, the click to copy button on code blocks and the edit source buttons are now opt-in.

This PR re-enables those features, as well as takes advantage of the new view source button. Previously the edit button was being used to view the source, so the edit_uri has been fixed to that it opens the true edit URL and the new view source button has been enabled.

Before

Screen Shot 2023-04-10 at 6 12 05 PM

After

Screen Shot 2023-04-10 at 6 12 13 PM

@ekoleda-codaio ekoleda-codaio added the documentation Related to the documentation in /docs. label Apr 10, 2023
@ekoleda-codaio ekoleda-codaio requested a review from a team as a code owner April 10, 2023 22:13
Copy link
Collaborator

@jonathan-codaio jonathan-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! I was looking to copy an example the other day and was wondering where the button went.

@ekoleda-codaio ekoleda-codaio merged commit 99f562d into main Apr 10, 2023
2 checks passed
@ekoleda-codaio ekoleda-codaio deleted the ek-mkdocs9 branch April 10, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to the documentation in /docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants