Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: show LSM viewer URL in db lsm command #3609

Merged
merged 1 commit into from May 14, 2024

Conversation

RaduBerinde
Copy link
Member

We now show the LSM viewer URL as well in the pebble db lsm command.
An --omit-url flag can be used to omit it (e.g. if generating one on
a very large LSM is too slow).

@RaduBerinde RaduBerinde requested a review from a team as a code owner May 11, 2024 16:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde requested a review from jbowens May 14, 2024 13:28
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @RaduBerinde and @sumeerbhola)


-- commits line 6 at r1:
nit: should we do the inverse of opting into the URL? or only generate the URL if it'll be reasonably sized (looks like Google Chrome allows URLs of up to 2MB)? I'm a little wary of it being slow but not knowing that there's an --omit-url flag to make it fast.

@sumeerbhola sumeerbhola requested a review from jbowens May 14, 2024 15:56
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jbowens and @RaduBerinde)

We add a `--url` flag to the `pebble db lsm` command which prints out
an LSM viewer URL.
Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jbowens)


-- commits line 6 at r1:

Previously, jbowens (Jackson Owens) wrote…

nit: should we do the inverse of opting into the URL? or only generate the URL if it'll be reasonably sized (looks like Google Chrome allows URLs of up to 2MB)? I'm a little wary of it being slow but not knowing that there's an --omit-url flag to make it fast.

Yeah I agree, done.

@RaduBerinde RaduBerinde merged commit 5597cf1 into cockroachdb:master May 14, 2024
11 checks passed
@RaduBerinde RaduBerinde deleted the lsm-view-cmd branch May 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants