tool: add more summaries to manifest summarize #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were motivated by some disagg storage experimentation. There
are summaries for compacted in bytes and files. Also, a histogram
of file lifetimes when the file gets deleted. The classification of
what is a compaction is slightly improved, and there is some small
cleanup (unused field).
On a real manifest, in verbose mode (for the lifetime histograms) the
output looks like:
_______L0_______L1_______L2_______L3_______L4_______L5_______L6_____TOTAL
2024-05-01T12:00:00Z
Ingest+Flush Bytes 16GB . . . . . . 16GB
Ingest+Flush Bytes/s 4.5MB/s . . . . . . 4.5MB/s
Compact Out Bytes 16GB . 32GB 36GB 36GB 32GB . 151GB
Compact Out Bytes/s 4.5MB/s . 9.0MB/s 10MB/s 10MB/s 9.1MB/s . 43MB/s
Compact In Bytes/s . . 9.0MB/s 10MB/s 10MB/s 9.5MB/s 7.7MB/s 47MB/s
Compact In Files/s . . 2.8/s 2.1/s 1.2/s 0.6/s 0.2/s 6.8/s
<snip>
Lifetime histograms
2024-05-01T12:00:00Z
L0: mean: 15s p25: 10s p50: 15s p75: 21s p90: 26s
L2: mean: 14s p25: 6s p50: 13s p75: 22s p90: 28s
L3: mean: 1m7s p25: 13s p50: 1m3s p75: 1m39s p90: 2m23s
L4: mean: 5m53s p25: 15s p50: 5m19s p75: 10m7s p90: 14m23s
L5: mean: 34m10s p25: 35s p50: 30m55s p75: 59m43s p90: 1h21m3s
L6: mean: 3h34m3s p25: 2h42m7s p50: 4h24m31s p75: 5h7m11s p90: 5h41m19s
<snip>
|
This change is |
RaduBerinde
approved these changes
May 15, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were motivated by some disagg storage experimentation. There are summaries for compacted in bytes and files. Also, a histogram of file lifetimes when the file gets deleted. The classification of what is a compaction is slightly improved, and there is some small cleanup (unused field).
On a real manifest, in verbose mode (for the lifetime histograms) the output looks like:
_______L0_______L1_______L2_______L3_______L4_______L5_______L6_____TOTAL
2024-05-01T12:00:00Z
Ingest+Flush Bytes 16GB . . . . . . 16GB
Ingest+Flush Bytes/s 4.5MB/s . . . . . . 4.5MB/s
Compact Out Bytes 16GB . 32GB 36GB 36GB 32GB . 151GB
Compact Out Bytes/s 4.5MB/s . 9.0MB/s 10MB/s 10MB/s 9.1MB/s . 43MB/s
Compact In Bytes/s . . 9.0MB/s 10MB/s 10MB/s 9.5MB/s 7.7MB/s 47MB/s
Compact In Files/s . . 2.8/s 2.1/s 1.2/s 0.6/s 0.2/s 6.8/s
Lifetime histograms
2024-05-01T12:00:00Z
L0: mean: 15s p25: 10s p50: 15s p75: 21s p90: 26s
L2: mean: 14s p25: 6s p50: 13s p75: 22s p90: 28s
L3: mean: 1m7s p25: 13s p50: 1m3s p75: 1m39s p90: 2m23s
L4: mean: 5m53s p25: 15s p50: 5m19s p75: 10m7s p90: 14m23s
L5: mean: 34m10s p25: 35s p50: 30m55s p75: 59m43s p90: 1h21m3s
L6: mean: 3h34m3s p25: 2h42m7s p50: 4h24m31s p75: 5h7m11s p90: 5h41m19s