Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring physical cluster replication into GA v24.1 #18538

Merged
merged 5 commits into from May 16, 2024
Merged

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented May 10, 2024

Fixes DOC-10255

This PR moves physical cluster replication into GA:

  • Removes all the preview label from the general PCR pages (leaves the preview label on the VIRTUAL CLUSTER SQL pages) (v24.1)
  • Adjusts the naming to move toward the PCR acronym. Uses physical cluster replication (PCR) for the first instance on each page in the docs that mentions PCR. (v23.2 + v24.1)
  • Removed the data verification line from the overview page. (v23.2 + v24.1)
  • Updates the performance testing numbers. (v24.1)

Copy link

github-actions bot commented May 10, 2024

Files changed:

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 2b452f3
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66462b485b75e00007a4c07b

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 2b452f3
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66462b48eb00db000844eaca

Copy link

netlify bot commented May 10, 2024

Netlify Preview

Name Link
🔨 Latest commit 2b452f3
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66462b485c3f1e0008a56a83
😎 Deploy Preview https://deploy-preview-18538--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox force-pushed the ga-pcr-updates branch 3 times, most recently from 7f867fb to ac1e315 Compare May 13, 2024 18:03
{{site.data.alerts.end}}

## Known limitations

{% include {{ page.version.version }}/known-limitations/physical-cluster-replication.md %}

## Performance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dt Can you check that these performance numbers look OK?

@kathancox kathancox marked this pull request as ready for review May 13, 2024 18:06
@kathancox kathancox requested a review from alicia-l2 May 13, 2024 18:06
Cockroach Labs supports PCR up to the following scale:

- Cluster size: 30TB
- Nodes: 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicia-l2 I think we can say we support far more than 7 nodes? anything up to ~30 seems like it should behave roughly as expected.

Copy link

@alicia-l2 alicia-l2 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to mention the nodes at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed


- Cluster size: 30TB
- Nodes: 7
- Transaction payload: [TPC-C]({% link {{ page.version.version }}/cockroach-workload.md %}#tpcc-workload)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicia-l2 Should we break this list up into "Cockroach Labs Supports: ..." which just lists cluster size metrics (TB, nodes, WPS) and then "Our testing with the TPC-C has demonstrated that:..." ? Because we support far more than just the tpcc workload; we support any sql workload you want, as long as it doesn't include large schema changes or imports. We just only verified performance with the tpcc workload.

Copy link

@alicia-l2 alicia-l2 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, except I think we should take nodes out and keep RPS. We could say "Our testing with TPC-C has demonstrated that we support workloads up to the following scale:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, done

Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry I accidentally started a review instead of just commenting!)

- Writes: 10,000 writes per second
- Reads: 18,000 reads per second
- [Replication lag]({% link {{ page.version.version }}/physical-cluster-replication-technical-overview.md %}) (steady state, no bulk changes): 20–45 seconds
- [Replication lag]({% link {{ page.version.version }}/physical-cluster-replication-technical-overview.md %}) (bulk changes / schema changes): Infinite

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this and add a note at the bottom that using PCR with frequent large schema changes or imports may cause significant spike in replication lag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done!

@@ -11,15 +11,15 @@ docs_area: deploy

{% include_cached new-in.html version="v23.2" %} This page gives an overview of _cluster virtualization_ in CockroachDB {{page.version.version}}. Cluster virtualization allows you to separate a cluster's _control plane_ from its _data plane_. The cluster's control plane manages cluster nodes and node-to-node traffic, while its data plane reads data from and writes data to the cluster's storage.

Cluster virtualization is required for [Physical Cluster Replication]({% link {{ page.version.version }}/physical-cluster-replication-overview.md %}). Creating virtual clusters without the intent of using them as either a physical cluster replication source or target is not yet supported.
Cluster virtualization is required for [**Physical cluster replication (PCR)**]({% link {{ page.version.version }}/physical-cluster-replication-overview.md %}). Creating virtual clusters without the intent of using them as either a PCR primary or standby is not yet supported.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it is supported but just in preview?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it is supported in the the product, but do we intend to support users who create multiple virtual clusters? I think last release we wanted to avoid users creating multiple virtual clusters other than for PCR. Happy to remove the sentence though, if we don't think it is helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the language around this.

@@ -66,7 +66,7 @@ cockroach sql --url \

This section shows how to connect using the [DB Console]({% link {{ page.version.version }}/ui-overview.md %}) when cluster virtualization is enabled.

Unless you specify which virtual cluster to connect to, when you connect using the DB Console, you are logged into the default virtual cluster. When [Physical Cluster Replication]({% link {{ page.version.version }}/physical-cluster-replication-overview.md %}) is enabled, the default virtual cluster is named `application`.
Unless you specify which virtual cluster to connect to, when you connect using the DB Console, you are logged into the default virtual cluster. When [PCR]({% link {{ page.version.version }}/physical-cluster-replication-overview.md %}) is enabled, the default virtual cluster is named `application`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth specifying that the user has to connect to the standby cluster when trying to see replication lag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this to v24.1 was not sure if the replication lag db console metric was backported.

@kathancox kathancox requested a review from alicia-l2 May 15, 2024 13:47
Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@Amruta-Ranade Amruta-Ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kathancox kathancox merged commit cdbd83b into main May 16, 2024
6 checks passed
@kathancox kathancox deleted the ga-pcr-updates branch May 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants