update and clean up migration docs #18527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
update shadowing caveats and some terminology
taroface
force-pushed
the
migration-docs-cleanup
branch
from
35f3fb8
to
8d7e724
Compare
taroface
force-pushed
the
migration-docs-cleanup
branch
from
f332c3e
to
d32e2e3
Compare
taroface
force-pushed
the
migration-docs-cleanup
branch
from
dbdd408
to
cd295b8
Compare
taroface
changed the title
taroface
requested review from
Jeremyyang920,
ajstorm,
ryanluu12345 and
ZhouXing19
ZhouXing19
reviewed
May 14, 2024
There was a problem hiding this comment.
Just left some nit comments. LGTM in general, but would like to leave the other members to finalize the review.
But IIRC from the meeting offsite, are we going to restructure the doc for LMS in future PRs, i.e. one page for testing only (shadowing) and another for production (replication and consistent cutover)?
ryanluu12345
approved these changes
May 14, 2024
|
TFTRs! There is plenty of iteration left to do on these docs. In the interest of getting some important updates published, though, I'm moving this on to docs review. I can continue working on these topics in future PRs. |
mdlinville
approved these changes
May 16, 2024
Co-authored-by: Matt Linville (he/him) <linville@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-8216
DOC-8221
DOC-9187
DOC-9192