Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to UDF, stored procs, and PL/pgSQL functionality #18495

Merged
merged 12 commits into from
May 8, 2024
Merged

updates to UDF, stored procs, and PL/pgSQL functionality #18495

merged 12 commits into from
May 8, 2024

Conversation

taroface
Copy link
Contributor

@taroface taroface commented Apr 23, 2024 •
edited

DOC-9695
DOC-9698
DOC-9667
DOC-9966
DOC-9617
DOC-9842
DOC-9985
DOC-9923
DOC-9882
DOC-9873
DOC-9956
DOC-9883

Document the following:

  • UDFs support DEFAULT values.
  • EXIT and CONTINUE syntax and labels.
  • PL/pgSQL nested blocks.
  • OUT/INOUT parameters.
  • Routines calling routines.
  • SELECT INTO STRICT / RETURNING INTO STRICT.
  • Explicit transactions within PL/pgSQL stored procedures.

@taroface taroface changed the title UDfs support DEFAULT values [WIP] UDfs support DEFAULT values Apr 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited

Files changed:

@taroface taroface changed the title [WIP] UDfs support DEFAULT values [WIP] updates to UDF, stored procs, and PL/pgSQL functionality Apr 23, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 31f18c6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/663bec7d12df0f00076aa5c2

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 31f18c6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/663bec7d32bf520008379e0b

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

✅ Netlify Preview

Name Link
🔨 Latest commit 31f18c6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/663bec7de7158f0008537b61
😎 Deploy Preview https://deploy-preview-18495--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taroface taroface changed the title [WIP] updates to UDF, stored procs, and PL/pgSQL functionality updates to UDF, stored procs, and PL/pgSQL functionality May 3, 2024
DrewKimball
DrewKimball reviewed May 3, 2024
View reviewed changes
Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/create-function.md Show resolved Hide resolved
src/current/v24.1/create-function.md Show resolved Hide resolved
src/current/v24.1/create-procedure.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/user-defined-functions.md Outdated Show resolved Hide resolved
@taroface
Copy link
Contributor Author

taroface commented May 3, 2024

@DrewKimball TFTR!! I think I addressed everything.

DrewKimball
DrewKimball approved these changes May 3, 2024
View reviewed changes
Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@taroface taroface requested a review from mdlinville May 6, 2024 15:17
yuzefovich
yuzefovich approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have just a few suggestions.

src/current/v24.1/create-procedure.md Outdated Show resolved Hide resolved
src/current/v24.1/user-defined-functions.md Outdated Show resolved Hide resolved
mdlinville
mdlinville approved these changes May 6, 2024
View reviewed changes
src/current/_includes/v24.1/known-limitations/plpgsql-feature-limitations.md Outdated Show resolved Hide resolved
src/current/v24.1/create-function.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Outdated Show resolved Hide resolved
src/current/v24.1/plpgsql.md Show resolved Hide resolved
@taroface taroface enabled auto-merge (squash) May 8, 2024 21:20
@taroface taroface merged commit 4cd0904 into main May 8, 2024
7 checks passed
@taroface taroface deleted the plpgsql-udf-24.1 branch May 8, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

@mdlinville mdlinville mdlinville approved these changes

@DrewKimball DrewKimball DrewKimball approved these changes

@mgartner mgartner Awaiting requested review from mgartner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taroface @yuzefovich @mdlinville @DrewKimball