Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-9409] Documentation for Folders Public Preview #18333

Merged
merged 3 commits into from May 14, 2024
Merged

[DOC-9409] Documentation for Folders Public Preview #18333

merged 3 commits into from May 14, 2024

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Feb 29, 2024

[DOC-9409] Documentation for Folders public preview

The following are user-facing:

  • [CC-25168]: The initial Org Admin now is granted Folder Admin automatically
  • [CC-26663]: Org-wide Folder Admins can now view all users and service accounts

Reviews requested:
@janmorales7 for UI
@fantapop for API
@kannanlakshmi for Product (and dates)
@rmloveland for docs

TODO

  • Add the Public Preview admonition
  • Write the release notes for the above

Previews

src/current/cockroachcloud/authorization.md
src/current/cockroachcloud/folders.md
src/current/cockroachcloud/managing-access.md

Copy link

github-actions bot commented Feb 29, 2024

Files changed:

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 362716b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6643e907853dc0000816b359

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 362716b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6643e90721145e0008f23b32

Copy link

netlify bot commented Feb 29, 2024

Netlify Preview

Name Link
🔨 Latest commit 362716b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6643e907e004af00080cc60e
😎 Deploy Preview https://deploy-preview-18333--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@janmorales7 janmorales7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdlinville mdlinville requested review from rmloveland and removed request for zaneteh-crl April 23, 2024 21:22
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had some non-blocking suggestions and questions

src/current/cockroachcloud/authorization.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/authorization.md Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/managing-access.md Show resolved Hide resolved
Copy link
Contributor

@kannanlakshmi kannanlakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge and release these any time between now and 24.1 launch. I don't have a strong preference for the date. But the feature will be publicly available same time as 24.1.0.

Separate comment thats not blocking this PR -- its quite hard to understand all the actions a role can take. Can we consider summarizing these in a table for a single view where the rows are actions (eg create cluster, view bill, create folder, invite users) and columns are roles like org admin, cluster admin etc.

@mdlinville mdlinville changed the title [DOC-9409] Documentation for Folders GA (WIP) [DOC-9409] Documentation for Folders Public Preview May 14, 2024
@mdlinville
Copy link
Contributor Author

LGTM, we can merge and release these any time between now and 24.1 launch. I don't have a strong preference for the date. But the feature will be publicly available same time as 24.1.0.

Separate comment thats not blocking this PR -- its quite hard to understand all the actions a role can take. Can we consider summarizing these in a table for a single view where the rows are actions (eg create cluster, view bill, create folder, invite users) and columns are roles like org admin, cluster admin etc.

Tracked the role doc improvement in https://cockroachlabs.atlassian.net/browse/DOC-10285.

- [CC-25168]: The initial Org Admin now get Folder Admin automatically
- [CC-26663]: Org-wide Folder Admins can now view all users and service accounts
- [CC-26452]: Roles can now be edited when a user is invited
src/current/cockroachcloud/authorization.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/authorization.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/folders.md Show resolved Hide resolved
src/current/cockroachcloud/folders.md Outdated Show resolved Hide resolved
@mdlinville mdlinville enabled auto-merge (squash) May 14, 2024 22:44
@mdlinville mdlinville merged commit 44c69c0 into main May 14, 2024
6 of 7 checks passed
@mdlinville mdlinville deleted the DOC-9409 branch May 14, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants