Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump google.golang.org/api to 0.97.0 #90738

Closed
wants to merge 1 commit into from

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Oct 26, 2022

Bump google.golang.org/api to 0.97.0. This version contains the fix for the first request GCS chunked uploads not being retried.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little wary of the gRPC bump, but at this point I'll take anything that fixes the gcs errors.

Are we already bumped to that gRPC version on master and 22.2?

@dt
Copy link
Member

dt commented Oct 27, 2022

looks like master is still on grpc 1.46. Maybe we do this bump on master and 22.2 first, then backport to 22.1 once it has a chance to bake a bit?

@msbutler
Copy link
Collaborator

bleh, i think 0.97.0 doesn't even build with cockroach bc of googleapis/google-api-go-client#1715

I think we'd need to bump to 0.100.0 at least

Bump google.golang.org/api to 0.101.0. This version contains the fix for the
first request GCS chunked uploads not being retried. Bump pubsub version to
maintain compatibility.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants