Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: workload: Bump prepare timeout to 90 minute #89118

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2022

Backport 1/1 commits from #88641 on behalf of @andrewbaptist.

/cc @cockroachdb/release


Relates to #72083. Allow scatter to complete.

Release note: None


Release justification: Test only change

Relates to #72083. Allow scatter to complete.

Release note: None
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-88641 branch from 5419975 to 68c1add Compare September 30, 2022 21:04
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 30, 2022

This change is Reviewable

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 30, 2022
@srosenberg
Copy link
Member

bors r=aayushshah15

@craig
Copy link
Contributor

craig bot commented Oct 3, 2022

Build failed:

@srosenberg
Copy link
Member

bors r-

@srosenberg srosenberg merged commit d201fd2 into release-22.2 Oct 3, 2022
@srosenberg srosenberg deleted the blathers/backport-release-22.2-88641 branch October 3, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants