clisqlshell: new testing flag --no-line-editor
#87690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20220909-no-line-editor
branch
from
c3bd37d
to
d89e07e
Compare
knz
force-pushed
the
20220909-no-line-editor
branch
2 times, most recently
from
49ee30f
to
fad15db
Compare
|
CI flake from #87700 |
knz
force-pushed
the
20220909-no-line-editor
branch
from
fad15db
to
06f47a5
Compare
otan
approved these changes
Sep 18, 2022
| func InterruptSelf() error { | ||
| pr, err := os.FindProcess(os.Getpid()) | ||
| if err != nil { | ||
| // No-op. |
There was a problem hiding this comment.
Does this noop comment also intend a return err here?
When running the interactive tests, when a test fails we want to be able to investigate the test logs without noise from the terminal escape codes. This patch adds a new flag `--no-line-editor` that can be used in these tests. (It can also arguably be used to demonstrate visually the differences between having a line editor and not having one.) Release note: None
knz
force-pushed
the
20220909-no-line-editor
branch
from
06f47a5
to
5d9f6cb
Compare
|
TFYR bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #86457.
When running the interactive tests, when a test fails we want to be able to investigate the test logs without noise from the terminal escape codes.
This patch adds a new flag
--no-line-editorthat can be used in these tests.(It can also arguably be used to demonstrate visually the differences between having a line editor and not having one.)
Release note: None