storage,roachpb: surface iterator {cached,} block counts in traces #82083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Release note: None
Adds plumbing for surfacing the # of blocks read in total + from the pebble block cache, things we're now tracking down in pebble: github.com/cockroachdb/pebble/pull/1729. These numbers can come in handy when reasoning about block cache hit rates for slow scans. Release note: None
|
This change is |
|
CI failure is unrelated: #81881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plumbing for surfacing the # of blocks read in total + from the
pebble block cache, things we're now tracking down in pebble:
cockroachdb/pebble/pull/1729. These numbers can come in handy
when reasoning about block cache hit rates for slow scans.
Release note: None
First commit is from #81942. Second commit will be dropped once cockroachdb/pebble#1729 merges and pebble is bumped on master to pick it up.