Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: downgrade grpc to v1.46.0 #81987

Merged
merged 1 commit into from May 30, 2022
Merged

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented May 27, 2022

Downgrade grpc to v1.46.0 as it was causing TestGossipOrphanedStallDetection
to flake under stress.

Release note: None

Downgrade grpc to v1.46.0 as it was causing TestGossipOrphanedStallDetection
to flake under stress.

Release note: None
@rhu713 rhu713 requested a review from a team as a code owner May 27, 2022 20:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713
Copy link
Contributor Author

rhu713 commented May 27, 2022

This should fix #81881

Verified with

./dev test ./pkg/gossip --filter=TestGossipOrphanedStallDetection --stress --stress-args=--maxruns=5000

@ajwerner
Copy link
Contributor

grpc/grpc-go@1303098 is the only relevant commit in the upstream. Seems not great that that patch causes problems for us. Maybe worth understanding and telling the grpc folks.

@irfansharif
Copy link
Contributor

I'm going to go ahead and bors this for you, it's tripping up CI.

bors r=nvanbenschoten

@irfansharif irfansharif linked an issue May 30, 2022 that may be closed by this pull request
@craig
Copy link
Contributor

craig bot commented May 30, 2022

Build succeeded:

@craig craig bot merged commit e7da9ba into cockroachdb:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gossip: TestGossipOrphanedStallDetection failed
5 participants