ccl/changefeedccl: set sarama to use kafka version 1.0 and later #64970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Kafka sink didn't specify a version to sarama, so it defaulted to the minimum version of 0.8.2. This behavior has been changed in the latest version of sarama to use version 1.0 of the Kafka API. Information on why this change was made by sarama can be found here: IBM/sarama#1787 Resolves cockroachdb#64842 Release note (enterprise change): Set the Kafka CDC sink to use the 1.0 version of the Kafka API.
rkruze
requested review from
a team and
adityamaru
and removed request for
a team
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
|
Thanks again for the contribution and the help investigating the root cause! We merged a fix to 20.2 that makes the Kafka version configurable to handle this, so I think we are OK not bumping the default for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Kafka sink didn't specify a version to sarama, so it
defaulted to the minimum version of 0.8.2. This behavior has been
changed in the latest version of sarama to use version 1.0 of the
Kafka API. Information on why this change was made by sarama can be
found here:
IBM/sarama#1787
Resolves #64842
Release note (enterprise change): Set the Kafka CDC sink to use the 1.0
version of the Kafka API.