Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: fix TestValidationWithProtectedTS flake #124161

Merged
merged 1 commit into from
May 14, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 14, 2024

Backport 1/1 commits from #123750 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, the test TestValidationWithProtectedTS would hang if a Ggio routine would hit an error, since a channel would not be posted on a error. It would also not gracefully handle TS after replica GC errors on transactions, which could happen on overloaded machines. To address this patch makes the test more resilient to the Go routine hitting errors so that it doesn't time out, and adds retry logic for TS after replica GC errors.

Fixes: #123447
Release note: None


Release justification: test only change

Previously, the test TestValidationWithProtectedTS would hang if a Go
routine would hit an error, since a channel would not be posted. It
would also not gracefully handle TS after replica GC errors on
transactions, which could happen on overloaded machines. To address this
patch makes the test more resilient to the Go routine hitting errors so
that it doesn't time out, and adds retry logic for TS after replica GC
errors.

Fixes: #123447
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 14, 2024 19:03
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 14, 2024
@blathers-crl blathers-crl bot requested a review from rafiss May 14, 2024 19:03
Copy link
Author

blathers-crl bot commented May 14, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit a3f8083 into release-24.1 May 14, 2024
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.1-123750 branch May 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants