-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: add tpcc OR roachtest #123942
Merged
Merged
roachtest: add tpcc OR roachtest #123942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
force-pushed
the
butler-tpcc-roachtest-or
branch
9 times, most recently
from
May 17, 2024 16:50
f6a9f6e
to
ab87934
Compare
This patch adds a 400 GB and a 8.5 TB (skipped) Online Restore TPCC roachtest. Epic: none Release note: none
This patch adds a few tables to the roachtest cluster before OR begins to better exercise prefix synthesis. This patch also adds a check to ensure all data was downloaded at the end of the download job. Epic: none Release note: none
This patch disables the consistency queue and enables kv.range_merge.skip_external_bytes.enabled, which skips adding replicas to the merge queue if they contain external bytes. Epic: none Release note: none
msbutler
force-pushed
the
butler-tpcc-roachtest-or
branch
from
May 22, 2024 17:58
ab87934
to
235ae09
Compare
msbutler
requested review from
nameisbhaskar,
vidit-bhat,
kev-cao and
a team
and removed request for
a team,
nameisbhaskar and
vidit-bhat
May 22, 2024 17:58
kev-cao
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tftr! bors r=kev-cao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a 400 GB and 8.5 TB Online Restore TPCC roachtest.
Epic: none
Release note: none