sql: fix error with DROP VALUE and DROP SCHEMA in same txn #123562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
added
backport-23.2.x
|
This change is |
Release note (bug fix): Fixed a bug that would occur when `ALTER TYPE ... DROP VALUE` is followed by `DROP SCHEMA CASCADE ...` in the same transaction. Previously, the `ALTER TYPE` schema change would get queued up to run at commit time, but by that point, the type may have already been removed, so the commit could fail. This is fixed now.
rafiss
force-pushed
the
fix-drop-value-drop-schema
branch
from
bca824d
to
dc0816e
Compare
fqazi
approved these changes
May 3, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
tftr! bors r+ |
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #123539
fixes #123488
fixes #121828
fixes #122785
Release note (bug fix): Fixed a bug that would occur when
ALTER TYPE ... DROP VALUEis followed byDROP SCHEMA CASCADE ...in the same transaction. Previously, theALTER TYPEschema change would get queued up to run at commit time, but by that point, the type may have already been removed, so the commit could fail. This is fixed now.