Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlinstance: write backwards compatible binary version #123520

Commits on May 3, 2024

  1. sqlinstance: write backwards compatible binary version

    We keep track of sql instances in multi-tenant deployments using the
    `system.sql_instances` table. One of the columns in this table is
    `binary_version`: this is the encoding of the version that the sql
    instance is running. SQL instances know how to reach each other by
    reading from that table (more accurately, setting up a rangefeed on
    that table and updating a local cache).
    
    In cockroachdb#115223, we introduced a new, more understandable string
    representation of cockroach internal versions. This new format is,
    however, backwards incompatible: older releases of cockroach are not
    able to parse it. As a result, a mixed-version multi-tenant
    deployments may face errors if some of the instances are running an
    internal version: the older releases won't be able to parse the new
    version format. As a result, the cache will be stale and we might see
    query errors and distsql timeouts.
    
    In this commit, we introduce a backwards compatible implementation of
    the the string representation of a version. Specifically, we continue
    to use the old format if the minimum supported version is less than
    24.1 (the version in which the new formatting was added). This commit
    should eventually be reverted when we no longer support versions older
    than 24.1.
    
    Epic: none
    
    Release note: None
    renatolabs committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2b607a5 View commit details
    Browse the repository at this point in the history