Skip to content

Commit

Permalink
Makefile: always use cockroach-short for file generation
Browse files Browse the repository at this point in the history
This defaults to the full `cockroach` executable which requires pulling
in all the UI stuff. Use `cockroach-short` to make generation require
fewer dependencies.

Release note: None
  • Loading branch information
rickystewart committed Sep 8, 2022
1 parent 5b8a6e2 commit b050bab
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -997,13 +997,11 @@ $(go-targets): override LINKFLAGS += \
$(COCKROACH) $(COCKROACHOSS) go-install: override LINKFLAGS += \
-X "github.com/cockroachdb/cockroach/pkg/build.utcTime=$(shell date -u '+%Y/%m/%d %H:%M:%S')"

settings-doc-gen = $(if $(filter buildshort,$(MAKECMDGOALS)),$(COCKROACHSHORT),$(COCKROACH))
docs/generated/settings/settings.html: $(COCKROACHSHORT)
@$(COCKROACHSHORT) gen settings-list --format=rawhtml > $@

docs/generated/settings/settings.html: $(settings-doc-gen)
@$(settings-doc-gen) gen settings-list --format=rawhtml > $@

docs/generated/settings/settings-for-tenants.txt: $(settings-doc-gen)
@$(settings-doc-gen) gen settings-list --without-system-only > $@
docs/generated/settings/settings-for-tenants.txt: $(COCKROACHSHORT)
@$(COCKROACHSHORT) gen settings-list --without-system-only > $@

SETTINGS_DOC_PAGES := docs/generated/settings/settings.html docs/generated/settings/settings-for-tenants.txt

Expand Down

0 comments on commit b050bab

Please sign in to comment.