testserver: short circuit downloading before making a request #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the testserver would always make a get request to download the cockroach binary. This commit short circuits the download logic to avoid making the initial request if the file already exists.
pawalt
force-pushed
the
pawalt/binary_shortcircuit
branch
from
2e712c1
to
cee2e1f
Compare
rickystewart
approved these changes
Nov 17, 2023
rafiss
reviewed
Nov 17, 2023
| if err != nil { | ||
| return "", err | ||
| } | ||
| localFile := filepath.Join(os.TempDir(), filename) |
There was a problem hiding this comment.
curious how the short-circuiting will work. won't localFile be different each time this is called, since os.TempDir would return a different directory?
There was a problem hiding this comment.
No. You may be thinking of MkdirTemp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the testserver would always make a get request to download
the cockroach binary. This commit short circuits the download logic to
avoid making the initial request if the file already exists.