package.json: Update @patternfly/react-console

[github-actions]

• Blocked on Bug - [VncConsole] - [Release 4.49.8 broke VncConsole causing random disconnects] patternfly/patternfly-react#8373

[github-actions]

Please manually check features related to these files:

package.json:    "@patternfly/react-console": "4.53.14",
src/components/vm/consoles/consoles.jsx:import { AccessConsoles } from "@patternfly/react-console";
src/components/vm/consoles/desktopConsole.jsx:import { DesktopViewer } from '@patternfly/react-console';
src/components/vm/consoles/vnc.jsx:import { VncConsole } from '@patternfly/react-console';

[martinpitt]

Seems ok, but we need to validate that the "unexpected connection close" messages from the inline console are legit, and accept them.

[martinpitt]

The disconnect messages appear during self.goToVmPage("subVmTest1"), which already auto-connects to the VNC console. In the JS log I see several error: Disconnection timed out. messages and a warning: WebSocket on-error event and info: Connection lost: but not where exactly they come from.

Anything else after that doesn't produce these messages any more. I had expected these during the reboot, or from the end of the test where it forcibly stops the cockpit session (as the test doesn't log out cleanly), but that's not it.

Switching between VM overview and details reproduces these. However, at this point this is too deep inside the react-console code that I can make sense of it quickly.

[skobyda]

I debugged a bit and found the was introduced between version 4.49.7 -> 4.49.8, probably in this only commit of that release: patternfly/patternfly-react@e024073#diff-bf986d61c9b208d09c9cff07c052d59c216f3f9f5abb28fd745813052de6ec27

[skobyda]

journalct error comes from cockpit-ws: connection unexpectedly closed by peer

WebSocket connection to 'ws:<URL>/cockpit/channel/2b600fea4a5b24e59cddee8c001ce7224619dc2718f99337a3378cea21745343?eyJwYXlsb2FkIjoic3RyZWFtIiwicHJvdG9jb2wiOiJiaW5hcnkiLCJiaW5hcnkiOiJyYXciLCJhZGRyZXNzIjoiMTI3LjAuMC4xIiwicG9ydCI6NTkwMH0=' failed: WebSocket is closed before the connection is established.

WebSocket connection to 'ws://127.0.0.2:9091/cockpit/channel/2b600fea4a5b24e59cddee8c001ce7224619dc2718f99337a3378cea21745343?eyJwYXlsb2FkIjoic3RyZWFtIiwicHJvdG9jb2wiOiJiaW5hcnkiLCJiaW5hcnkiOiJyYXciLCJhZGRyZXNzIjoiMTI3LjAuMC4xIiwicG9ydCI6NTkwMH0=' failed: WebSocket is closed before the connection is established.

[jelly]

This is now on 4.92.54 so feels worthy to retry.

[jelly]

So this is still broken.

[KKoukiou]

Sent a PR upstream to fix the react-console. patternfly/patternfly-react#8374

[martinpitt]

version 4.93.10 got released, which should hopefully contain the fix. As this is all conflict-y, let's just close this and let our workflows build a fresh PR?

[martinpitt]

Impatient as I am, I triggered the workflow manually and got PR #884. Crossing fingers! 🤞