Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image refresh for fedora-35 #2960

Merged
merged 1 commit into from Feb 28, 2022
Merged

Conversation

@github-actions github-actions bot added the bot label Feb 18, 2022
@cockpituous
Copy link
Contributor

image-refresh in progress on 3-ci-srv-04.
Log: https://logs.cockpit-project.org/logs/image-refresh-2960-20220218-021616/

@cockpituous
Copy link
Contributor

image-refresh in progress on 4-cockpit-10.
Log: https://logs.cockpit-project.org/logs/image-refresh-2960-20220218-021616/

@cockpituous cockpituous changed the title Image refresh for fedora-35 WIP: 3-ci-srv-04: [no-test] Image refresh for fedora-35 Feb 18, 2022
@cockpituous cockpituous changed the title Image refresh for fedora-35 WIP: 4-cockpit-10: [no-test] Image refresh for fedora-35 Feb 18, 2022
@cockpituous
Copy link
Contributor

cockpituous pushed a commit that referenced this pull request Feb 18, 2022
@cockpituous cockpituous force-pushed the image-refresh-fedora-35-20220218-023636 branch from 7fb9ea1 to 68b5313 Compare February 18, 2022 02:36
@cockpituous cockpituous changed the title WIP: 4-cockpit-10: [no-test] Image refresh for fedora-35 Image refresh for fedora-35 Feb 18, 2022
@martinpitt
Copy link
Member

@KKoukiou, @M4rtinK : You mentioned the python thing yesterday, are you on that?

@martinpitt
Copy link
Member

Oh, it's part of rhinstaller/anaconda#3875 , blocking on that

@martinpitt
Copy link
Member

Anaconda is broken on the current image as well, as that's related to the tasks container refresh, not the f35 image.

However, the stratis pixel test failure is odd. It's highly unlikely that it is related to the image, but let's retry and compare.

@martinpitt
Copy link
Member

Anaconda got unblocked, but the stratis pixel test failure stays. Needs investigation.

@mvollmer
Copy link
Member

However, the stratis pixel test failure is odd.

Looks exactly like the updates we did in cockpit-project/cockpit#17013, hmm.

@mvollmer
Copy link
Member

However, the stratis pixel test failure is odd.

Looks exactly like the updates we did in cockpit-project/cockpit#17013, hmm.

Seems like #2877 is fixed and we now run more of the tests.

@mvollmer
Copy link
Member

Blocked on cockpit-project/cockpit#17051

martinpitt pushed a commit that referenced this pull request Feb 25, 2022
@martinpitt martinpitt force-pushed the image-refresh-fedora-35-20220218-023636 branch from 68b5313 to fa4d4ff Compare February 25, 2022 10:58
@martinpitt
Copy link
Member

All blockers resolved. I pushed a clean rebase.

@martinpitt
Copy link
Member

This now fails on a whole slew of new eslint errors. Could possibly be related to the eslint breakage worked around in cockpit-project/cockpit-machines#597 , but possibly the new eslint version just became a whole lot stricter.

@martinpitt
Copy link
Member

martinpitt commented Feb 28, 2022

I checked the eslint errors in c-podman; locally I don't get the "missing key" errors any more, just the two react/jsx-indent errors, and they are both bogus. The parser gets thoroughly confused.

starter-kit builds fine for me locally, even though on CI last week it ran into several key-errors as well.

The key errors were all due to jsx-eslint/eslint-plugin-react#3215 , so I'll do a round of retries to get an up to date status.

@martinpitt martinpitt force-pushed the image-refresh-fedora-35-20220218-023636 branch from fa4d4ff to 1f8ce41 Compare February 28, 2022 07:20
@martinpitt
Copy link
Member

Auf ein neues!

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last! 🥳

@martinpitt martinpitt merged commit 78d6799 into main Feb 28, 2022
@martinpitt martinpitt deleted the image-refresh-fedora-35-20220218-023636 branch February 28, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants