[FEATURE] Search for members on paginated member page

[aerugo]

As an admin, I want to be able to search for a user by name on the member page of my group or round (for example to change the users' balance or to upgrade them to admin).

• Search on Round member list page Add search for members on paginated member page (#369) #545
• Search on Group member list page

terminology: in the code, rounds are sometimes called collections or events. Groups are sometimes called organizations/orgs.

[aerugo]

related #307 /j

[Powersource]

fwiw there's some member searching added to the api in #525 that might be reusable/usable for inspiration

[aerugo]

Ping @SeunghunSunmoonLee

[shsunmoonlee]

Just followed README and I got an error. Help would be appreciated @aerugo
ReferenceError: Cannot access 'WEBPACK_DEFAULT_EXPORT' before initialization

➜  ui git:(main) ✗ yarn dev
yarn run v1.22.4
$ yarn run generate
$ yarn run generate:prisma
$ prisma generate
Environment variables loaded from .env
Prisma schema loaded from server/prisma/schema.prisma

✔ Generated Prisma Client (3.4.1) to ./node_modules/@prisma/client in 344ms
You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client

import { PrismaClient } from '@prisma/client'
const prisma = new PrismaClient()

$ next dev
ready - started server on 0.0.0.0:3000, url: http://localhost:3000
info  - Loaded env from /Users/seunghunlee/Software/cobudget/ui/.env.local
info  - Loaded env from /Users/seunghunlee/Software/cobudget/ui/.env.development
info  - Loaded env from /Users/seunghunlee/Software/cobudget/ui/.env
info  - Disabled SWC as replacement for Babel because of custom Babel configuration ".babelrc" https://nextjs.org/docs/messages/swc-disabled
event - compiled client and server successfully in 2.9s (2113 modules)
wait  - compiling / (client and server)...
info  - Using external babel configuration from /Users/seunghunlee/Software/cobudget/ui/.babelrc
event - compiled client and server successfully in 1483 ms (2116 modules)
wait  - compiling /api...
event - compiled client and server successfully in 431 ms (2160 modules)
wait  - compiling /_error (client and server)...
error - ReferenceError: Cannot access '__WEBPACK_DEFAULT_EXPORT__' before initialization
event - compiled client and server successfully in 292 ms (2161 modules)

[Powersource]

@SeunghunSunmoonLee it's a strange bug since neither Gustav nor I are getting it, but both you and also another person I've heard get it. But it seems to be fixed by vercel/next.js#33831 , however that pr doesn't seem to have ended up in a normal release yet so you might have to update to a canary version of next, e.g. 12.0.11-canary.9

[shsunmoonlee]

Thank you @Powersource ! Now I can run it after setting env variable after getting another error.

Error: Add MAGIC_LINK_SECRET environment variable

Is there a better solution to access members page without having to change the code to determine authenticated or not?

[aerugo]

Just add some random strings to your .env.local file. For example: COOKIE_SECRET="A_LONG_RANDOM_VALUE_THAT_IS_NOT_THIS_STRING123" ***@***.***:35432/cobudget" POSTMARK_FROM_EMAIL="fake" POSTMARK_API_TOKEN="fake" MAGIC_LINK_SECRET="SOMETHING" ***@***.***"

…

On Wed, Feb 9, 2022 at 3:23 PM Seunghun Sunmoon Lee < ***@***.***> wrote: Thank you @Powersource <https://github.com/Powersource> ! Now I'm getting Error: Add MAGIC_LINK_SECRET environment variable — Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3MU6K27P4GEDG6VSUURNDU2KBHZANCNFSM5HOI2KGA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Powersource]

Is there a better solution to access members page without having to change the code to determine authenticated or not?

How do you mean? It should be enough to be logged in as a member of the collection.

[aerugo]

@SeunghunSunmoonLee - to log in with a magic link, you use the link that is printed to terminal when you try to log in with any email.

[aerugo]

Did you get it to work @SeunghunSunmoonLee?

[shsunmoonlee]

Yeah. I have WIP solution. Can you let me push?

➜  cobudget git:(369-search-for-members) git push --set-upstream origin 369-search-for-members
remote: Permission to cobudget/cobudget.git denied to SeunghunSunmoonLee.
fatal: unable to access 'https://github.com/cobudget/cobudget.git/': The requested URL returned error: 403

[shsunmoonlee]

@Powersource I've used your implementation. I got error with usernameStartsWith.

CombinedError {name: 'CombinedError', message: '[GraphQL] Unknown argument "usernameStartsWith" on field "MembersPage.members".', graphQLErrors: Array(1), networkError: undefined, response: Response}

Do you have any clue on this?

Not sure why MembersPage resolver is reading members from db while members do the same?

[Powersource]

@SeunghunSunmoonLee MembersPage is(/was? I think we might have switched to another one in some/all places) our solution for pagination.

For that error, when adding an argument to a graphql resolver you need to add it in a few different places, including in the graphql schema.

[aerugo]

@SeunghunSunmoonLee open a pull request and @gustavlrsn or @Powersource will review. :)
Our main branch deploys directly to production.

[Powersource]

i think he's trying to push to a new branch in our repo. that would be fine but he'd need more permissions.

@SeunghunSunmoonLee i think it's simplest if you create a fork on github and push to that one instead

[shsunmoonlee]

Here it is :) #545

[francesca-sp]

Following a discussion in today's meeting, I've added this new issue to improve the search options for the round members: #555 ping @SeunghunSunmoonLee

[Powersource]

there's also a bug that you have to currently search case-sensitively for names but i think that has the same cause as #554 which i'll fix today (i think i might refactor the two resolvers into one)

[Powersource]

@SeunghunSunmoonLee assigned this to you since iirc you were still gonna work on cobudget, just not very much per month?

[shsunmoonlee]

Hey! Which ticket? #554 or #555?
ah this ticket is open again. I see. So requirement is improve the search options I guess?
@Powersource

[Powersource]

@SeunghunSunmoonLee yep this issue, i've updated the description a tad to clarify. specifically we want

Search on Group (aka org) member list page

We currently only have it on the Round (aka collection) page

[Powersource]

This issue should be closable now. As mentioned in the PR, new features to test:

• pagination on round members page
• search on group members page
• ability to search on email on the round members list (for admins only)

[francesca-sp]

The last 2 bullet points are working, and for pagination, I'm trying to test it - but it's not even kicking in with a list of 27 members. As of how many members is pagination supposed to start? @Powersource

[francesca-sp]

@Powersource did you see the above question of mine? So that we can close this....

[gustavlrsn]

@francesca-sp the pagination limit is 30

[francesca-sp]

thanks @gustavlrsn . Just tested this with a round, and for me pagination does not seem to be working. When I go above 30, then simply the "load more" button shows up, and I need to unfold the list to load the remaining emails. Is that what is supposed to happen? @Powersource

This is the one: https://staging.cobudget.com/staging-group/my-staging-round/participants

[gustavlrsn]

Hm, I only see 3 participants in that list. But unsure what you mean with the load more behavior. Clicking the button should add up to 30 more records in the same list. We're adding automatic "infinite scrolling" in another issue, so that you don't need to press the button manually.

[francesca-sp]

that's very odd, there are 31 people in that list.

My understanding was that this issue is about "pagination", which I understand as pages showing up that you switch between, once you reach above 30. Is that incorrect?

[gustavlrsn]

Right, as a non-admin I can only see people that have accepted the invitation.

Ah, yes, confusing term, it is pagination more in the technical sense of dividing up the result in "pages", to avoid loading everything at once

[francesca-sp]

ok, I understand now. So in that case, this seems to be working and can be closed.

[gustavlrsn]

Great, closing this