-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable black linting for this repository #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first work on this repo from you! I have two small suggestions:
- Let's add a final newline.
- Let's add a pre-commit config like Cobbler has it to keep the setups more similar to each other.
Codecov ReportBase: 53.30% // Head: 53.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 53.30% 53.30%
=======================================
Files 6 6
Lines 756 756
=======================================
Hits 403 403
Misses 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@tiltingpenguin This is something I didn't know before reading it up... Could you please add the C0330 to out pylint ignore file in this repository due to: psf/black#48 The problem is in pylint and not in black but the black formatting triggers that Codacy/Pylint errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR aims to enable black linting in the Github CI for this repository
fixes: #46