Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable black linting for this repository #49

Merged
merged 4 commits into from
Dec 12, 2022
Merged

enable black linting for this repository #49

merged 4 commits into from
Dec 12, 2022

Conversation

tiltingpenguin
Copy link
Collaborator

This PR aims to enable black linting in the Github CI for this repository

fixes: #46

@SchoolGuy SchoolGuy self-requested a review December 12, 2022 07:52
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first work on this repo from you! I have two small suggestions:

  • Let's add a final newline.
  • Let's add a pre-commit config like Cobbler has it to keep the setups more similar to each other.

@SchoolGuy SchoolGuy added this to the v1.0.0 milestone Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 53.30% // Head: 53.30% // No change to project coverage 👍

Coverage data is based on head (c223bdf) compared to base (f0c341b).
Patch coverage: 36.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files           6        6           
  Lines         756      756           
=======================================
  Hits          403      403           
  Misses        353      353           
Flag Coverage Δ
unittests 53.30% <36.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/enums.py 100.00% <ø> (ø)
libcobblersignatures/models/osbreed.py 94.23% <0.00%> (ø)
libcobblersignatures/__init__.py 94.50% <87.50%> (ø)
libcobblersignatures/models/osversion.py 93.90% <100.00%> (ø)
libcobblersignatures/utils.py 82.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SchoolGuy
Copy link
Member

@tiltingpenguin This is something I didn't know before reading it up... Could you please add the C0330 to out pylint ignore file in this repository due to: psf/black#48

The problem is in pylint and not in black but the black formatting triggers that Codacy/Pylint errors.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit ed4dd99 into main Dec 12, 2022
@SchoolGuy SchoolGuy deleted the enable-black branch December 12, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Enable black for this repository
2 participants