refactor: Convert to assert_fs/assert_cmd #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
commented
Jun 13, 2018
tests/cli.rs
Outdated
| .unwrap() | ||
| .assert() | ||
| .failure() | ||
| .stderr(&predicate::str::contains("requires a subcommand").from_utf8()); |
There was a problem hiding this comment.
I should add an IntoOutput that automatically converts str predicates.
| assert_dirs_eq(&destination, &target); | ||
| let expected = format!("tests/target/{}", name); | ||
| let expected_path = Path::new(&expected); | ||
| assert_dirs_eq(&destination, expected_path); |
There was a problem hiding this comment.
Replacing our custom dir-diffing is assert-rs/predicates-rs#33
tests/cli.rs
Outdated
| .current_dir(project_root.path()) | ||
| .assert() | ||
| .success() | ||
| .stdout(&predicate::str::is_empty().from_utf8()) |
There was a problem hiding this comment.
Can't move forward with this until assert-rs/predicates-rs#7
epage
changed the title
The tests are now operating in a more standard use case thanks to the ability to easily setup. The are running in the CWD rather than all the paths artifically being set. Fixes cobalt-org#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test case for assert_fs / assert_cmd to identify areas to improve the API