This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
Fix datepicker input always being disabled #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @davidstritzl Take in account that this package is deprecated by @matheo/datepicker for Angular v11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the datepicker input element always being disabled regardless of the
disabledinput attribute. This is caused by passing a boolean for the disabled attribute to the host input element, which will be implicitly converted to the strings"true"or"false", dependently on the boolean value, however, according to the HTML5 standard, boolean attributes with false values must be left out completely (and true values can be either an empty string or the attribute name itself).