Update flatbuffers to 22.9(resolved RUSTSEC-2021-0122) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The old version of flatbuffers has some problems: Generated code can read and write out of bounds in safe code.
See this rustsec link or Github Issue.
What changes are included in this PR?
Note that flatbuffers now uses flatbuffers::Vector instead of slices in generated models.
Build script
common/protos/build.rswill detect environment variableFLATC_PATHpointing to the executableflatc. You can use your own flatc to build protos.export FLATC_PATH=/Tools/flatbuffers/flatc make buildAre there any user-facing changes?