feat: rework lib #325
Draft
feat: rework lib #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/rewrite
branch
from
8d611b1
to
2753026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some of the ideas from #310 in a v7 compatible way
Example usage: Julusian/node-jpeg-turbo@master...Julusian:node-jpeg-turbo:wip/cmake-js-overhaul
So far:
add_librarywhich should be used instead. Note: only tested on linux and lightly on windows so far (verified by performing build with system cmake), it needs work for windows and macos