Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect Visual Studio 2019 platform #201

Merged
merged 3 commits into from Feb 26, 2020

Commits on Dec 13, 2019

  1. Add support for "-A" option

    VS 2019 doesn't have the platform name in its name anymore, to generate the files for a specific platform you need to use "-A" option when invoking CMake.
    WopsS authored and gjasny committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a5cf0d8 View commit details
    Browse the repository at this point in the history
  2. Auto-detect VS2019 platform

    The CMake Visual Studio 2019 Generator does not support the Win64
    or ARM suffix on the generator name. Instead the generator platform
    must be set explicitly via the platform parameter.
    
    Before this patch the platform was not set at all which results
    in CMake picking the host architecture. This obviously leads
    to mismatches if a 32bit NodeJS is used on a 64bit Windows.
    
    Right now the platform parameter is only applied for Visual
    Studio 16 because cmake-js does not specify a minimum CMake
    version. If at least CMake 3.1 (released December 2014)
    would be required the platform selection code could be made
    unconditional and thus forward-compatible with newer CMake
    Visual Studio generators.
    
    Thanks to @WopsS for cmake-js#177 which added platform parameter support.
    gjasny committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    668155f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Update documentation

    gjasny committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    b19acfd View commit details
    Browse the repository at this point in the history