Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create support for arm64 architecture for docker images. #564

Merged
merged 3 commits into from
May 9, 2024
Merged

Create support for arm64 architecture for docker images. #564

merged 3 commits into from
May 9, 2024

Conversation

kfirtoledo
Copy link
Collaborator

Create support for arm64 architecture for docker images:

  1. Update the GitHub action.
  2. Update the makefile to compile images according to the architecture
  3. Update the docker file to use the correct binary file.
  4. Update the push image command to use the --platform flag for multi-architecture Docker image compilation.
  5. Update the iperf3 demo to support arm64 architecture.

@kfirtoledo kfirtoledo requested a review from zivnevo May 6, 2024 19:49
@kfirtoledo kfirtoledo force-pushed the arm64 branch 2 times, most recently from 4e4d2fa to f37d304 Compare May 8, 2024 05:31
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 8, 2024
elevran
elevran approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming the fetch-tags: true was dropped intentionally. If not - please fix before merging.

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
demos/iperf3/cloud/test.py Show resolved Hide resolved
demos/iperf3/testdata/manifests/iperf3-client/iperf3-client.yaml Show resolved Hide resolved
demos/utils/cloud.py Show resolved Hide resolved
@kfirtoledo
demos: Fix iPerf3 demo to support arm64
384dd0a 
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
@kfirtoledo
Docker: Create support to arm64 architecture for docker images
1dc6f50 
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
@kfirtoledo
small fix
a3aa6fa 
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
elevran
elevran approved these changes May 9, 2024
View reviewed changes
.github/workflows/release.yml Show resolved Hide resolved
@kfirtoledo kfirtoledo merged commit 7650794 into clusterlink-net:main May 9, 2024
9 checks passed
@kfirtoledo kfirtoledo deleted the arm64 branch May 9, 2024 07:05
@kfirtoledo kfirtoledo added the enhancement New feature or request label May 9, 2024
@kfirtoledo kfirtoledo linked an issue May 13, 2024 that may be closed by this pull request
[FEATURE]: Support Linux platform with architecture of arm64 #561
Closed
@elevran elevran mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevran elevran elevran approved these changes

@zivnevo zivnevo Awaiting requested review from zivnevo

@orozery orozery Awaiting requested review from orozery orozery is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Support Linux platform with architecture of arm64
2 participants
@kfirtoledo @elevran