Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and examples #66

Merged
merged 1 commit into from Feb 11, 2024
Merged

Improve documentation and examples #66

merged 1 commit into from Feb 11, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Feb 2, 2024 •
edited

SimonFrings
SimonFrings requested changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quickstart example could use the same adjusted as in your clue/reactphp-shell PR

@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 1ee8e37 to 28ca26e Compare February 6, 2024 07:49
@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 28ca26e to f7023cf Compare February 7, 2024 07:38
@yadaiio
Copy link
Contributor Author

yadaiio commented Feb 7, 2024

Thanks to @SimonFrings I got a better understanding for the then() method used in the examples. See also https://reactphp.org/promise/#promiseinterfacethen. Everything should be fixed right now. 👍

@clue clue added the documentation Improvements or additions to documentation label Feb 11, 2024
@clue clue added this to the v0.5.0 milestone Feb 11, 2024
clue
clue approved these changes Feb 11, 2024
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit d8b43be into clue:master Feb 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings requested changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yadaiio @clue @SimonFrings