Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 8.3 and update test suite #147

Merged
merged 1 commit into from Nov 25, 2023
Merged

Run tests on PHP 8.3 and update test suite #147

merged 1 commit into from Nov 25, 2023

Conversation

yadaiio
Copy link
Collaborator

@yadaiio yadaiio commented Nov 24, 2023

This pull request builds on top of #136 and #119.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

@yadaiio yadaiio changed the title Run PHP 8.3 and update test suite Run tests on PHP 8.3 and update test suite Nov 24, 2023
@clue clue added this to the v3.0.0 milestone Nov 25, 2023
clue
clue approved these changes Nov 25, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit d4e16d3 into clue:3.x Nov 25, 2023
16 checks passed
@SimonFrings SimonFrings mentioned this pull request Dec 21, 2023
Closed
@clue clue mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yadaiio @clue