Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reactphp/async instead of clue/reactphp-block #135

Closed
wants to merge 1 commit into from

Conversation

dinooo13
Copy link
Contributor

@dinooo13 dinooo13 commented Oct 1, 2022

@SimonFrings
Copy link
Collaborator

@dinooo13 thanks for opening this PR 👍

This project uses the StreamSelectLoop instead of the default loop inside the test suite which is why switching them results in failing tests. This also means we can't switch from clue/reactphp-block to reactphp/async without adjusting this API first, because the React\Async\await() function doesn't accept a loop parameter.

@clue in I will look into switching to the default loop in another pull request, let's keep this open until this problem is fixed.

@dinooo13
Copy link
Contributor Author

dinooo13 commented Oct 4, 2022

Ahh I was scratching my head what I have broken switching to the async package 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants