Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reactphp/async instead of clue/reactphp-block #50

Closed
wants to merge 1 commit into from

Conversation

dinooo13
Copy link
Contributor

@dinooo13 dinooo13 commented Oct 4, 2022

Copy link
Collaborator

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing I noticed

tests/FunctionalTest.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request here looks good, let's get this in 👍

@SimonFrings
Copy link
Collaborator

@dinooo13 Just noticed, the test suite is currently not running through as it can be seen in #53 and we need to update our test suite. @yadaiio created a pull request for this in #54. Once this is merged we have to come back to this one here and rebase once. Additionally, we'll probably encounter a conflict in the composer.json file when rebasing, as #54 updates the PHPUnit versions which are right below you changes.

I will give an update in here once #54 is merged so we can move on and get this pull request in 👍

@SimonFrings
Copy link
Collaborator

@dinooo13 With #54 merged I think we can rebase in here and then get this in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants