[Rebased] Support for custom HTTP headers #17
Conversation
|
Any info on the merge of this PR ? +1 for adding a 0.1 tag to the project ! |
|
Ping @clue 🙂 |
As HTTP headers are case insensitive, this function ensures default headers are not overriden, even by another case
bpolaszek
force-pushed
the
customHeaders
branch
from
d9ab9fb
to
a649939
Compare
|
Time to ping again - @clue could you please review? |
|
@bpolaszek Thanks for looking into this and the friendly reminder! I'm currently in the process of applying some major upgrades to @reactphp that will also affect this project here. Once this done, I'll make sure take a look at this again as soon as time permits 👍 |
|
@clue No worries 🙂 I assume you're kinda busy with X-Framework 🍿 No emergency on my side, I'll ping you again in a few months when I'll cleanup my forks 😄 |
|
@bpolaszek I continued the conversation in #10 👍 |
|
I've just filed reactphp/http#449 as a way to keep track of this ticket upstream and believe this is the best way to address this 👍 In the meantime, I'll assume this one is resolved and will close this for now, please feel free to report back otherwise 👍 |
Hello @clue,
This one is a rebased version of #10. When you've got some little time, could you please review this?
If you merge, please co-author @qharnay since he did the biggest part of the job :-)
Do you plan to tag a 0.1? I'll soon require that dependency on a production app (server listening to a Mercure server, with authentication) and even if not considered stable, at least avoid relying
dev-masterin case of breaking changes.Thank you much!
Ben