Run tests on PHP 8.3 and update test suite #38
Conversation
There was a problem hiding this comment.
Looks good so far, I have two suggestions that are currently missing from this PR:
- Can you also update the comment inside the
phpunit.xml.legacy, similar to my changes in ReactPHP CSV - We also use these PRs to improve the indentation inside the
composer.json, similar to my changes in ReactPHP CSV
|
It also seems like the tests for HHVM are currently failing, didn't notice while reviewing. Can you look into this? |
yadaiio
force-pushed
the
test_suite
branch
2 times, most recently
from
b87442d
to
abef992
Compare
Done! Thank you @SimonFrings 馃憤 |
It seems like we give an Tests are running green now. 馃憤
|
yadaiio
force-pushed
the
test_suite
branch
4 times, most recently
from
fe72147
to
5b3960e
Compare
| @@ -24,6 +28,16 @@ | |||
| "react/socket": "^1.12" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^9.3 || ^5.7 || ^4.8" | |||
| "phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36" | |||
| }, | |||
Builds on top of #30, #35, #36 and #37.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.
After this is merged, I also want to create another pull request that fix the typos, improve the documentation. 馃憤