Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: support SetCustomFormValueFunc to define custom ctx.FormValue #473

Merged

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Dec 8, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

支持 SetCustomFormValueFunc 用于自定义 ctx.FormValue 函数,内部库提供类似 net/http 的实现。

Which issue(s) this PR fixes:

Sorry, something went wrong.

@li-jin-gou li-jin-gou marked this pull request as ready for review December 8, 2022 15:45
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 69.65% // Head: 69.64% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9ed9503) compared to base (fefa4e1).
Patch coverage: 71.79% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
- Coverage    69.65%   69.64%   -0.02%     
===========================================
  Files           93       93              
  Lines         8736     8752      +16     
===========================================
+ Hits          6085     6095      +10     
- Misses        2290     2296       +6     
  Partials       361      361              
Impacted Files Coverage Δ
pkg/app/context.go 84.30% <66.66%> (-0.54%) ⬇️
pkg/route/engine.go 63.19% <100.00%> (+0.49%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/app/client/client.go 74.68% <0.00%> (+1.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch from e7e447e to 1b12633 Compare December 10, 2022 05:39
@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch from 1b12633 to c4661df Compare December 12, 2022 03:46
@FGYFFFF FGYFFFF requested review from a team as code owners December 14, 2022 03:41
Duslia
Duslia previously approved these changes Dec 14, 2022
@li-jin-gou li-jin-gou added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Dec 14, 2022
@li-jin-gou
Copy link
Member Author

li-jin-gou commented Dec 14, 2022

Conclusion: Use engine.Set*** configuration.

@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch 3 times, most recently from 45a2253 to 58201a0 Compare December 14, 2022 07:25
@li-jin-gou li-jin-gou removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Dec 14, 2022
@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch from 58201a0 to efdefa2 Compare December 14, 2022 08:27
a631807682
a631807682 previously approved these changes Dec 14, 2022
Duslia
Duslia previously approved these changes Dec 14, 2022
@li-jin-gou li-jin-gou dismissed stale reviews from Duslia and a631807682 via 437149e December 15, 2022 14:38
@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch from efdefa2 to 437149e Compare December 15, 2022 14:38
@li-jin-gou li-jin-gou force-pushed the optimize/add_custom_formvaluefunc branch from 437149e to 9d0abe4 Compare December 15, 2022 14:49
@li-jin-gou li-jin-gou merged commit 7895df7 into cloudwego:develop Dec 17, 2022
@li-jin-gou li-jin-gou mentioned this pull request Feb 10, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants