feat: add ResponseHeader.contentEncoding #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wang-tsh
changed the title
|
@li-jin-gou plz approve running workflows & Review |
Codecov ReportBase: 69.53% // Head: 69.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #456 +/- ##
===========================================
+ Coverage 69.53% 69.61% +0.08%
===========================================
Files 93 93
Lines 8810 8834 +24
===========================================
+ Hits 6126 6150 +24
Misses 2320 2320
Partials 364 364
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@li-jin-gou I'd add some ut plz approve running workflows again |
|
@li-jin-gou plz review it ,thanks |
|
Please change the title to the standard format |
wang-tsh
changed the title
|
wang-tsh
changed the title
|
PTAL |
li-jin-gou
changed the title
Skyenought
reviewed
Dec 15, 2022
Skyenought
reviewed
Dec 15, 2022
|
最近新冠中，康复了之后我做一下修改发自我的 iPhone在 2022年12月15日，18:53，skyenought ***@***.***> 写道：
@Skyenought commented on this pull request.
In pkg/protocol/header.go:
@@ -224,6 +225,7 @@ func (h *ResponseHeader) CopyTo(dst *ResponseHeader) {
dst.statusCode = h.statusCode
dst.contentLength = h.contentLength
dst.contentLengthBytes = append(dst.contentLengthBytes[:0], h.contentLengthBytes...)
+ dst.contentEncoding = append(dst.contentEncoding, h.contentEncoding...)
dst.Reset() 中应该有这样的逻辑吧
h.contentEncoding = h.contentEncoding[:0]
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
welkeyever
reviewed
Dec 26, 2022
This reverts commit 46975c4.
…nto feat_AddHeaderContentEncoding
wang-tsh
requested review from
welkeyever and
Skyenought
and removed request for
welkeyever
welkeyever
reviewed
Dec 28, 2022
li-jin-gou
approved these changes
Dec 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
为ResponseHeader 添加 contentEncoding 及相关方法
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: Adding a new field contentEncoding into ResponseHeader
Also fix Referer and Tests
zh(optional): 为ResponseHeader 添加一个字段 contentEncoding 同时修改测试以及其他方法中的引用
Which issue(s) this PR fixes:
Fixes #449
refer to valyala/fasthttp#1311