Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario #421

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Nov 25, 2022

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

在 HTTP2 场景下,doRequestFollowRedirectsBuffer 不能获取到 body

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario. The affected interfaces include client.Getclient.GetTimeoutclient.GetDeadLineclient.Post
zh(optional): 在 HTTP2 场景下,doRequestFollowRedirectsBuffer 不能获取到 body,受影响的接口包括 client.Getclient.GetTimeoutclient.GetDeadLineclient.Post

Which issue(s) this PR fixes:

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 68.14% // Head: 68.19% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (03b4333) compared to base (d39a818).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
+ Coverage    68.14%   68.19%   +0.05%     
===========================================
  Files           90       90              
  Lines         8632     8630       -2     
===========================================
+ Hits          5882     5885       +3     
+ Misses        2389     2385       -4     
+ Partials       361      360       -1     
Impacted Files Coverage Δ
pkg/route/engine.go 62.69% <0.00%> (-0.20%) ⬇️
pkg/app/client/client.go 74.68% <0.00%> (+1.26%) ⬆️
pkg/protocol/response.go 82.78% <0.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Duslia Duslia changed the title fix: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario [WIP]fix: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario Nov 25, 2022
@Duslia Duslia force-pushed the fix/h2_client_nil_body branch 2 times, most recently from 2d116ec to 34491aa Compare November 25, 2022 08:34
@Duslia Duslia changed the title [WIP]fix: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario fix: doRequestFollowRedirectsBuffer cannot get body in HTTP2 scenario Nov 25, 2022
@Duslia Duslia force-pushed the fix/h2_client_nil_body branch from 34491aa to 0b700ce Compare November 25, 2022 08:36
li-jin-gou
li-jin-gou previously approved these changes Nov 25, 2022
@Duslia Duslia force-pushed the fix/h2_client_nil_body branch 2 times, most recently from 85a2624 to 8b7c37e Compare November 28, 2022 03:12
li-jin-gou
li-jin-gou previously approved these changes Nov 29, 2022
@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit 9b9ec92 into cloudwego:develop Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants