Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade version for urfave/cli to fix the help option #313

Merged
merged 1 commit into from Oct 20, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Oct 20, 2022

What type of PR is this?

build

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

升级 urfave/cli 的版本,解决 "help" 命令混乱的问题

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: upgrade version for urfave/cli to fix the help option
zh(optional): 升级 urfave/cli 的版本,解决 "help" 命令混乱的问题

Which issue(s) this PR fixes:

@FGYFFFF
Copy link
Contributor Author

FGYFFFF commented Oct 20, 2022

之前版本的 "urfave/cli" 在输入 "--help" 的时候有bug,会将所有的 flag 以首字母进行排序,导致打印出来的 help 模板 特别混乱。详见 pr: urfave/cli#1430

@welkeyever welkeyever changed the title feat: upgrade version for urfave/cli to fix the help option build: upgrade version for urfave/cli to fix the help option Oct 20, 2022
welkeyever
welkeyever previously approved these changes Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 64.50% // Head: 64.53% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (35ed12f) compared to base (c0d67a9).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 35ed12f differs from pull request most recent head b643262. Consider uploading reports for the commit b643262 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #313      +/-   ##
===========================================
+ Coverage    64.50%   64.53%   +0.02%     
===========================================
  Files           84       85       +1     
  Lines         8288     8300      +12     
===========================================
+ Hits          5346     5356      +10     
- Misses        2580     2583       +3     
+ Partials       362      361       -1     
Impacted Files Coverage Δ
pkg/app/middlewares/server/recovery/option.go 100.00% <100.00%> (ø)
pkg/app/middlewares/server/recovery/recovery.go 86.36% <100.00%> (-0.31%) ⬇️
pkg/common/compress/compress.go 81.90% <0.00%> (-1.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/hz/go.sum Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF merged commit 0fc30f9 into cloudwego:develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants