feat(hz): trim pb gopackage #1111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkeyever
reviewed
May 29, 2024
| @@ -291,12 +291,16 @@ func (plugin *Plugin) Handle(req *pluginpb.CodeGeneratorRequest, args *config.Ar | |||
| } | |||
|
|
|||
| // fixGoPackage will update go_package to store all the model files in ${model_dir} | |||
| func (plugin *Plugin) fixGoPackage(req *pluginpb.CodeGeneratorRequest, pkgMap map[string]string) { | |||
| func (plugin *Plugin) fixGoPackage(req *pluginpb.CodeGeneratorRequest, pkgMap map[string]string, args *config.Argument) { | |||
There was a problem hiding this comment.
加个“prefixToTrim string” 入参就够了？应该不需要传整个 args 进来
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
支持裁剪protobuf gopackage 的前缀
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: trim pb gopackage
zh(optional): 支持裁剪protobuf gopackage 的前缀
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: